Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for Advanced Markers #1243

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Oct 20, 2023

This PR updates our play-services-maps dependency to 18.2.0, introduces support for Advanced Markers and adds a sample.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Edit the title of this pull request with a semantic commit prefix (e.g. "fix: "), which is necessary for automated release workflows to decide whether to generate a new release and what type it should be.
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1242 🦕

demo/build.gradle Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n.b. mixing Markers with AdvancedMarkers should work, but is not recommended so we only demonstrate using one marker type at a time in the demo app.

No change needed, just noting this for future questions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n.b. This converts the renderer to the new upgraded renderer by default per https://developers.google.com/maps/documentation/android-sdk/release-notes#October_18_2023

No change needed, just putting this here for release notes.

@wangela wangela merged commit c4cd47c into main Oct 27, 2023
9 checks passed
@wangela wangela deleted the feat/added_support_for_advanced_markers branch October 27, 2023 19:21
googlemaps-bot pushed a commit that referenced this pull request Oct 27, 2023
# [3.7.0](v3.6.1...v3.7.0) (2023-10-27)

### Features

* add support for Advanced Markers ([#1243](#1243)) ([c4cd47c](c4cd47c)), closes [/developers.google.com/maps/documentation/android-sdk/release-notes#October_18_2023](https://github.com//developers.google.com/maps/documentation/android-sdk/release-notes/issues/October_18_2023)
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Advanced Markers
3 participants