Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests #4

Closed
markmandel opened this issue Jan 28, 2020 · 3 comments
Closed

Integration Tests #4

markmandel opened this issue Jan 28, 2020 · 3 comments
Labels
area/build-tools Development tooling. area/tests Unit tests, integration tests, anything to make sure things don't break

Comments

@markmandel
Copy link
Member

We should have some kind of integration / e2e tests. Not sure how we want to do this, but it makes sense to have this at somepoint.

I wonder if we could do something like Docker compose to setup complex proxy and network scenarios? Just a thought.

@markmandel markmandel added area/tests Unit tests, integration tests, anything to make sure things don't break area/build-tools Development tooling. labels Jan 28, 2020
@markmandel
Copy link
Member Author

Do we feel like we still need this ticket, or are the tests in https://github.com/googleforgames/quilkin/tree/master/tests satisfactory?

@iffyio
Copy link
Collaborator

iffyio commented Nov 14, 2020

Yeah, I think we can close it since those tests cover it, we can add any ones that are missing as we go along or create a separate issue later on if we decide to do more complex e2e testing

@markmandel
Copy link
Member Author

Sounds good to me 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. area/tests Unit tests, integration tests, anything to make sure things don't break
Projects
None yet
Development

No branches or pull requests

2 participants