Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miss makezero in slice init #1764

Open
alingse opened this issue May 27, 2024 · 0 comments
Open

miss makezero in slice init #1764

alingse opened this issue May 27, 2024 · 0 comments
Labels
kind/bug Something isn't working

Comments

@alingse
Copy link

alingse commented May 27, 2024

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242991979/job/25426536505

====================================================================================================
append to slice `tags` with non-zero initialized length at https://github.com/googleforgames/open-match/blob/main/examples/functions/golang/backfill/mmf/matchfunction.go#L231:11
====================================================================================================

the tags := make([]string, len(tagFilters)) should be tags := make([]string, 0, len(tagFilters))

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Output of kubectl version:

Cloud Provider/Platform (AKS, GKE, Minikube etc.):

Open Match Release Version:

Install Method(yaml/helm):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant