Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up e2e tests #511

Closed
markmandel opened this issue Jan 25, 2019 · 8 comments
Closed

Speed up e2e tests #511

markmandel opened this issue Jan 25, 2019 · 8 comments
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
1.2.0

Comments

@markmandel
Copy link
Member

markmandel commented Jan 25, 2019 •
edited
Loading

Two things for speeding up end to end tests:

  1. We can increase the -parallel setting on the e2e test command for our cloud build run, since it's mostly bound by the speed K8s processes our game servers, rather than cpu on the machine
  2. Since we're using more resources, running more in parrallel, we can set lower than the default requests and limits on all the gameservers we are creating. fleet.yaml is a good example.
@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jan 25, 2019
@jkowalski
Copy link
Contributor

I can work on that. Parallelism can't really be increased too much, until #497 is merged, otherwise the test becomes quite slow.

@markmandel
Copy link
Member Author

Point No.1 is complete. Still need to implement No.2

@aLekSer
Copy link
Collaborator

aLekSer commented Feb 20, 2019

I will open a small PR for Point 2.
Actually stress-test-e2e can be run on smaller clusters. (To reduce insufficientCPU errors on GS creating).

@aLekSer aLekSer mentioned this issue Feb 20, 2019
Merged
@roberthbailey
Copy link
Member

e2e tests are getting slow again.... tests on PRs are now consistently taking >40 minutes. We need to look at what is taking the most time and then we can decide what to try and optimize.

I've generated a graph of the build step dependencies for our cloudbuild:

buildgraph

in case that helps.

@markmandel
Copy link
Member Author

make build is now 20+ minutes to run. This is likely also a large culprit.

@markmandel
Copy link
Member Author

Can we close this now?

@markmandel
Copy link
Member Author

e2e tests are running at 4-5 minutes, so I think this can be closed now.

@markmandel
Copy link
Member Author

Doing some cleanup. I am going to close this, since I mentioned I would do it in September 😄

@markmandel markmandel added this to the 1.2.0 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
4 participants
@jkowalski @markmandel @aLekSer @roberthbailey