Fix cyclomatic complexity in cmd/controller/main.go

[EricFortin]

Remove the // nolint comment.

The main function has a cyclomatic complexity greater than 10. Refactor the function to lower it.

[enocom]

There's a consistent pattern in main.go where we start a goroutine and call Run on something, reporting an error if the call fails.

With some small refactoring, we could do this:

var rs []runner = []runner{                                                                                                                
    wh, gsController, gsSetController, fleetController, faController, health,                                                              
}                                                                                                                                          
for _, r := range rs {                                                                                                                     
    go func() {
        if err := r.Run(stop); err != nil {
            logger.Fatalf("component %s failed to start with error: %s", r, err)
        }
    }()                                                                                                                         
}                                                                                                                                          
<-stop                                                                                                                                     
logger.Info("Shut down agones controllers")

Alternatively, if that seems too fancy, we could also simple extract a named function for each started goroutine.

Thoughts?

[markmandel]

I've actually often wondered if each Controller should/could implement an interface, and if there was value in that - sounds like there might be. I'm definitely not adverse to this approach.

This kinda starts us down an opinionated framework for controllers path - which is not the end of the world.

[enocom]

I'll put together the PR with that pattern and we can revisit the question of making controllers implement a common interface.