Use gke-gcloud-auth-plugin in relay test #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires some hacks to make gcloud happy in the test environment. My last run failed because the relay client wasn't running, but that means that it can talk to GKE so is hopefully working again. Fixes b/293827843.
|
Thanks a lot for addressing this so quickly! |
hauke76
approved these changes
Jul 31, 2023
drigz
added a commit
that referenced
this pull request
Aug 2, 2023
This requires some hacks to make gcloud happy in the test environment. I confirmed that it fails with `TEST FAILED: id command did not run, output was ""`. b/293827843
hauke76
pushed a commit
that referenced
this pull request
Aug 2, 2023
This requires some hacks to make gcloud happy in the test environment. I confirmed that it fails with `TEST FAILED: id command did not run, output was ""`. b/293827843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires some hacks to make gcloud happy in the test environment. I confirmed that it fails with
TEST FAILED: id command did not run, output was "".b/293827843