You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bump k8s.io/client-go past v0.27.0 including transitively (#264)
When I ran `go mod graph | grep client-go` after the merge of:
- #263
I saw that our direct dependencies were still using `v0.25.X` of
`k8s.io/client-go` (transitively.)
e.g.
```
github.com/prometheus/prometheus@v0.39.1 k8s.io/client-go@v0.25.1
k8s.io/apiextensions-apiserver@v0.25.3 k8s.io/client-go@v0.25.3
k8s.io/cli-runtime@v0.25.3 k8s.io/client-go@v0.25.3
k8s.io/component-base@v0.25.3 k8s.io/client-go@v0.25.3
sigs.k8s.io/controller-runtime@v0.13.1 k8s.io/client-go@v0.25.0
```
We need a more recent version of client-go all throughout the stack to
support: #262
So this is my attempt to upgrade all dependencies which use client-go
transitively.
I'm not too strong in golang dependency management, so if I shouldn't
have done it this way, please let me know!!
Is there another smarter way to force all transitive declarations of a
particular dependency to be of a minimum version?
I ran:
```
go get -u sigs.k8s.io/controller-runtime
go get -u github.com/prometheus/prometheus
go get -u k8s.io/apiextensions-apiserver
go get -u k8s.io/cli-runtime
go mod tidy
```
Then `go mod graph | grep client-go` gives something which makes it seem
like `client-go` got upgraded all throughout the dependency tree:
```
github.com/googlecloudrobotics/core/src k8s.io/client-go@v0.28.4
github.com/prometheus/prometheus@v0.48.0 k8s.io/client-go@v0.28.2
k8s.io/apiextensions-apiserver@v0.28.4 k8s.io/client-go@v0.28.4
k8s.io/cli-runtime@v0.28.4 k8s.io/client-go@v0.28.4
k8s.io/client-go@v0.28.4 github.com/evanphx/json-patch@v4.12.0+incompatible
k8s.io/client-go@v0.28.4 github.com/gogo/protobuf@v1.3.2
k8s.io/client-go@v0.28.4 github.com/golang/groupcache@v0.0.0-20210331224755-41bb18bfe9da
k8s.io/client-go@v0.28.4 github.com/golang/protobuf@v1.5.3
k8s.io/client-go@v0.28.4 github.com/google/gnostic-models@v0.6.8
k8s.io/client-go@v0.28.4 github.com/google/go-cmp@v0.5.9
k8s.io/client-go@v0.28.4 github.com/google/gofuzz@v1.2.0
k8s.io/client-go@v0.28.4 github.com/google/uuid@v1.3.0
k8s.io/client-go@v0.28.4 github.com/gregjones/httpcache@v0.0.0-20180305231024-9cad4c3443a7
k8s.io/client-go@v0.28.4 github.com/imdario/mergo@v0.3.6
k8s.io/client-go@v0.28.4 github.com/peterbourgon/diskv@v2.0.1+incompatible
k8s.io/client-go@v0.28.4 github.com/spf13/pflag@v1.0.5
k8s.io/client-go@v0.28.4 github.com/stretchr/testify@v1.8.2
k8s.io/client-go@v0.28.4 golang.org/x/net@v0.17.0
k8s.io/client-go@v0.28.4 golang.org/x/oauth2@v0.8.0
k8s.io/client-go@v0.28.4 golang.org/x/term@v0.13.0
k8s.io/client-go@v0.28.4 golang.org/x/time@v0.3.0
k8s.io/client-go@v0.28.4 google.golang.org/protobuf@v1.31.0
k8s.io/client-go@v0.28.4 k8s.io/api@v0.28.4
k8s.io/client-go@v0.28.4 k8s.io/apimachinery@v0.28.4
k8s.io/client-go@v0.28.4 k8s.io/klog/v2@v2.100.1
k8s.io/client-go@v0.28.4 k8s.io/kube-openapi@v0.0.0-20230717233707-2695361300d9
k8s.io/client-go@v0.28.4 k8s.io/utils@v0.0.0-20230406110748-d93618cff8a2
k8s.io/client-go@v0.28.4 sigs.k8s.io/json@v0.0.0-20221116044647-bc3834ca7abd
k8s.io/client-go@v0.28.4 sigs.k8s.io/structured-merge-diff/v4@v4.2.3
k8s.io/client-go@v0.28.4 sigs.k8s.io/yaml@v1.3.0
k8s.io/client-go@v0.28.4 github.com/davecgh/go-spew@v1.1.1
k8s.io/client-go@v0.28.4 github.com/emicklei/go-restful/v3@v3.9.0
k8s.io/client-go@v0.28.4 github.com/go-logr/logr@v1.2.4
k8s.io/client-go@v0.28.4 github.com/go-openapi/jsonpointer@v0.19.6
k8s.io/client-go@v0.28.4 github.com/go-openapi/jsonreference@v0.20.2
k8s.io/client-go@v0.28.4 github.com/go-openapi/swag@v0.22.3
k8s.io/client-go@v0.28.4 github.com/google/btree@v1.0.1
k8s.io/client-go@v0.28.4 github.com/josharian/intern@v1.0.0
k8s.io/client-go@v0.28.4 github.com/json-iterator/go@v1.1.12
k8s.io/client-go@v0.28.4 github.com/mailru/easyjson@v0.7.7
k8s.io/client-go@v0.28.4 github.com/moby/spdystream@v0.2.0
k8s.io/client-go@v0.28.4 github.com/modern-go/concurrent@v0.0.0-20180306012644-bacd9c7ef1dd
k8s.io/client-go@v0.28.4 github.com/modern-go/reflect2@v1.0.2
k8s.io/client-go@v0.28.4 github.com/munnerz/goautoneg@v0.0.0-20191010083416-a7dc8b61c822
k8s.io/client-go@v0.28.4 github.com/onsi/gomega@v1.27.6
k8s.io/client-go@v0.28.4 github.com/pkg/errors@v0.9.1
k8s.io/client-go@v0.28.4 github.com/pmezard/go-difflib@v1.0.0
k8s.io/client-go@v0.28.4 golang.org/x/sys@v0.13.0
k8s.io/client-go@v0.28.4 golang.org/x/text@v0.13.0
k8s.io/client-go@v0.28.4 google.golang.org/appengine@v1.6.7
k8s.io/client-go@v0.28.4 gopkg.in/inf.v0@v0.9.1
k8s.io/client-go@v0.28.4 gopkg.in/yaml.v2@v2.4.0
k8s.io/client-go@v0.28.4 gopkg.in/yaml.v3@v3.0.1
k8s.io/component-base@v0.28.4 k8s.io/client-go@v0.28.4
sigs.k8s.io/controller-runtime@v0.16.3 k8s.io/client-go@v0.28.3
```
I understand this is a large scale change, so I would be open to
answering any questions!
Signed-off-by: methylDragon <methylDragon@google.com>
0 commit comments