Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sphinx conf.py for > 3.0.0 #570

Closed
crwilcox opened this issue May 19, 2020 · 4 comments · Fixed by #576
Closed

Update sphinx conf.py for > 3.0.0 #570

crwilcox opened this issue May 19, 2020 · 4 comments · Fixed by #576
Assignees
@busunkim96
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@crwilcox
Copy link
Contributor

Update templates to incorporate change seen at googleapis/python-bigtable#20

https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_library/docs/conf.py.j2
https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_library/noxfile.py.j2
@crwilcox
Copy link
Contributor Author

@kolea2

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 20, 2020
@SurferJeffAtGoogle
Copy link
Contributor

I don't have enough context to understand the problem alluded to in this bug description.

@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels May 20, 2020
@crwilcox
Copy link
Contributor Author

We were forced to pin sphinx due to a breaking change in 3.0.0+. This change has already been made in Bigtable, but other libraries will likely want the same change.

@SurferJeffAtGoogle
Copy link
Contributor

I see, so this bug is really a for-all-the-python-libraries bug? It seems orthogonal to synthtool.

This was referenced May 21, 2020
Closed
Closed
Closed
@kolea2 kolea2 mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update python docs template kolea2/synthtool
4 participants
@crwilcox @busunkim96 @SurferJeffAtGoogle @yoshi-automation