Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile - extension or file name for header checker? #1854

Open
shobsi opened this issue Aug 30, 2023 · 1 comment
Open

Dockerfile - extension or file name for header checker? #1854

shobsi opened this issue Aug 30, 2023 · 1 comment
Assignees
@shobsi
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@shobsi
Copy link

shobsi commented Aug 30, 2023

I noticed Dockerfile is listed as a file extension

synthtool/synthtool/gcp/templates/python_library/.github/header-checker-lint.yml

Line 9 in 59fe44f

"Dockerfile",

Would it apply if the file name itself is Dockerfile?
@SurferJeffAtGoogle SurferJeffAtGoogle added type: question Request for information or clarification. Not an issue. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 31, 2023
@leahecole
Copy link
Contributor

leahecole commented Aug 31, 2023 •
edited
Loading

I believe that's the intention, but if it's not functioning properly that way, we can definitely reconfigure! I haven't messed with this in awhile

Reassigning to you for further comments 😄

@leahecole leahecole assigned shobsi and unassigned leahecole Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shobsi shobsi

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @leahecole @shobsi @SurferJeffAtGoogle