Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When enabling include trailing delimiter option does not validate that a delimiter is set. #318

Open
emkornfield opened this issue Apr 27, 2022 · 0 comments
Open

When enabling include trailing delimiter option does not validate that a delimiter is set. #318

emkornfield opened this issue Apr 27, 2022 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@emkornfield
Copy link

This differs from the production GCS service which requires the delimiter to be set. it would be nice to do validation to match the error condition for tests that are run against testbench.
@emkornfield emkornfield added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 27, 2022
@emkornfield emkornfield mentioned this issue Apr 27, 2022
Merged
@coryan coryan added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coryan @emkornfield