chore: declare test-jar in GAX's testlib artifacts

[JoeWang1127]

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #1144 ☕️

[conventional-commit-lint-gcf]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

[suztomo]

Can you add source code comment why this test-jar is important?

[JoeWang1127]

done.

[suztomo]

Assuming this is the correct fix, will we need any change in the users of GAX’s testlib-classifier users?

[JoeWang1127]

Assuming this is the correct fix, will we need any change in the users of GAX’s testlib-classifier users?

I think they need to add <type>test-jar</type> in their pom file.

I found out this in the failing Kokoro checks

[ERROR]   The project com.google.cloud:google-cloud-accessapproval:2.13.0 (/tmpfs/src/github/gapic-generator-java/google-cloud-java/java-accessapproval/google-cloud-accessapproval/pom.xml) has 3 errors
[ERROR]     'dependencies.dependency.version' for com.google.api:gax:jar:testlib is missing. @ line 80, column 21
[ERROR]     'dependencies.dependency.version' for com.google.api:gax-grpc:jar:testlib is missing. @ line 86, column 17
[ERROR]     'dependencies.dependency.version' for com.google.api:gax-httpjson:jar:testlib is missing. @ line 92, column 17

[suztomo]

My own confirmation.

Remove local Maven repository cache: $ rm -rf ~/.m2/repository/com/google/api/gax*

Checkout main (not this pull request):

suztomo@suztomo-macbookpro.roam.internal ~/gapic-generator-java
~/gapic-generator-java $ git checkout main
Already on 'main'
Your branch is up to date with 'origin/main'.
suztomo@suztomo-macbookpro.roam.internal ~/gapic-generator-java
~/gapic-generator-java $ git pull
Already up to date.

Open gapic-generator-java project in IntelliJ and tried running the gapic-generator-java module's unit tests. It shows the error.

Now checkout this pull request.

~/gapic-generator-java $ gh pr checkout 1474

Run the unit tests in IntelliJ. It succeeded.

[suztomo]

@blakeli0 Can you confirm this pull request fixes the problem in your IntelliJ? (It worked form me)

[suztomo]

@JoeWang1127 'dependencies.dependency.version' for com.google.api:gax:jar:testlib is missing. @ line 80, column 21 came from the BOM's declaration of the artifacts. Do you really need that?

[JoeWang1127]

I think this line is needed to bring the test code.

[suztomo]

A BOM doesn't determine what code goes to JAR file.

[JoeWang1127]

There's an error in gapic-generator-java module if I delete this line and reload the project:

'dependencies.dependency.version' for com.google.api:gax-grpc:test-jar:testlib is missing.

[suztomo]

OK it’s for IntelliJ. Then it makes sense.

[blakeli0]

@blakeli0 Can you confirm this pull request fixes the problem in your IntelliJ? (It worked form me)

Yes, I verified that it's working now with Joe's fix. Thank you so much @JoeWang1127 !

[suztomo]

Trying an additional entry that does not carry "test-jar".

[JoeWang1127]

@suztomo thanks for the help.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[suztomo]

Thank you.