chore: Fix pre-commit. #1294

blakeli0 · 2023-02-03T22:36:48Z

Update pre-commit to use mvn install instead of mvn test as gapic-generator-java is dependent on gax test jars. This is also mimicking the same behavior in ci.

conventional-commit-lint-gcf · 2023-02-03T22:36:52Z

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

lqiu96 · 2023-02-07T19:15:45Z

Ran this locally with some Java changes:

(14:11:28) ERROR: /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/local_config_cc/BUILD:48:19: in cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'darwin_arm64'

Also would it be possible to just run mvn fmt:format in the git pre-commit hooks instead of having it fail and then running it seperately?

blakeli0 · 2023-02-07T19:52:08Z

Also would it be possible to just run mvn fmt:format in the git pre-commit hooks instead of having it fail and then running it seperately?

I would keep them separately as the pre-commit is supposed to be checks only, doing formatting also in pre-commit would mixing concerns. Also you would need to run git add . again to add the formatted files, which is something I don't think we should do as well in pre-commit

(14:11:28) ERROR: /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/local_config_cc/BUILD:48:19: in cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'darwin_arm64'

This might be an M1 only issue. Which step did it fail? Integration tests?

lqiu96 · 2023-02-07T20:54:28Z

Also would it be possible to just run mvn fmt:format in the git pre-commit hooks instead of having it fail and then running it seperately?

I would keep them separately as the pre-commit is supposed to be checks only, doing formatting also in pre-commit would mixing concerns. Also you would need to run git add . again to add the formatted files, which is something I don't think we should do as well in pre-commit

I see -- that's a valid point. The only reason I bring this up is because when I had formatting issue in the past, I've just ended up running mvn fmt:format immediately after. Unless there is a reason to spot check the formatting issues, I think it could be a nice QOL for the pre-commit hooks to just format it automatically.

(14:11:28) ERROR: /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/local_config_cc/BUILD:48:19: in cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'darwin_arm64'

This might be an M1 only issue. Which step did it fail? Integration tests?

More from the logs:

(14:11:28) ERROR: /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/local_config_cc/BUILD:48:19: in cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'darwin_arm64'
(14:11:28) INFO: Repository org_apache_tomcat_annotations_api instantiated at:
  /Users/lawrenceqiu/IdeaProjects/gapic-generator-java/WORKSPACE:23:37: in <toplevel>
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/com_google_api_gax_java/repositories.bzl:36:15: in com_google_api_gax_java_repositories
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/com_google_api_gax_java/repositories.bzl:139:14: in _maybe
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/bazel_tools/tools/build_defs/repo/jvm.bzl:285:24: in jvm_maven_import_external
Repository rule jvm_import_external defined at:
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/bazel_tools/tools/build_defs/repo/jvm.bzl:217:38: in <toplevel>
(14:11:28) INFO: Repository com_google_auto_value_auto_value instantiated at:
  /Users/lawrenceqiu/IdeaProjects/gapic-generator-java/WORKSPACE:23:37: in <toplevel>
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/com_google_api_gax_java/repositories.bzl:36:15: in com_google_api_gax_java_repositories
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/com_google_api_gax_java/repositories.bzl:139:14: in _maybe
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/bazel_tools/tools/build_defs/repo/jvm.bzl:285:24: in jvm_maven_import_external
Repository rule jvm_import_external defined at:
  /private/var/tmp/_bazel_lawrenceqiu/848933e5d291df54c266044a93c65004/external/bazel_tools/tools/build_defs/repo/jvm.bzl:217:38: in <toplevel>
(14:11:28) ERROR: Analysis of target '//test/integration:com.google.cloud.iam.credentials.v1.IAMCredentialsClientTest' failed; build aborted: Analysis of target '@local_config_cc//:toolchain' failed
(14:11:28) INFO: Elapsed time: 2.627s
(14:11:28) INFO: 0 processes.
(14:11:28) FAILED: Build did NOT complete successfully (76 packages loaded, 1502 targets configured)
(14:11:28) FAILED: Build did NOT complete successfully (76 packages loaded, 1502 targets configured)
    Fetching @remotejdk11_macos_aarch64; fetching

I think it looks to be from the golden ITs

lqiu96 · 2023-02-08T16:22:02Z

This was resolved when I used v5.x+ of bazel. Possible solution found via: bazelbuild/bazel#13514

May be helpful if someone else could try this as well to confirm.

sonarcloud · 2023-02-09T20:06:01Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

* fix: Allow custom http bindings for LROs * fix: Update generator and GAX to support custom HTTP Bindings for operations * fix: Use static Map for custom Operation REST Http Bindings * chore: Update golden test cases * chore: Update showcase tests * chore: Update golden ITs * chore: Add back origin HttpJsonOperationStub.create() methods * fix(deps): update dependency com.google.auth:google-auth-library-bom to v1.15.0 (#1278) * doc: Update DEVELOPMENT.md for local development. (#1237) * chore: Create a default mapping in OperationStub * chore: Do not generate custom bindings if there are none * chore: Update golden units * chore: Update all test cases * chore: Fix format issues * fix: remove constant operation binding field * chore: Clean up code * chore: Resolve sonar comments * chore: DEVELOPMENT.md formatting fix (#1289) * ci: use java-shared-dependencies in google-cloud-java repository for downstream test (#1291) * ci: use java-shared-dependencies in google-cloud-java * No need to modify google-cloud-jar-parent * fix(java): initialize netty-shaded at run-time and add reflection configurations for netty classes (#1290) * fix(java): initialize netty-shaded at run-time and add reflection configurations for netty classes * ci(showcase): disable rest_numeric_enum for showcase testing (#1284) * ci(showcase): disable rest_numeric_enum feature in showcase tests * chore(main): release 2.15.0 (#1269) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(main): release 2.15.1-SNAPSHOT (#1292) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: Pin Bazel version to 5.2.0 (#1304) Pin Bazel version to 5.2.0 as googleapis already updated to 5.2.0 * build(deps): bump cryptography from 38.0.3 to 39.0.1 in /.kokoro (#1297) Bumps [cryptography](https://github.com/pyca/cryptography) from 38.0.3 to 39.0.1. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@38.0.3...39.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mridula <66699525+mpeddada1@users.noreply.github.com> * chore: (cleanup) removing unused files (#1265) * chore: (cleanup) removing unused files * chore: working on comments * chore: removing unused Gradle files in api-common-java, gax-java, java-common-protos, and java-iam (#1305) The build is Maven or Bazel. The Gradle files in the recently migrated repositories (api-common-java, gax-java, java-common-protos, and java-iam) are not used. Note that this pull request is not touching rules_java_gapic/resources/gradle which is still used to generate Gradle files for self-service client libraries. * chore: updated gax-java contribution doc (#1334) Removing unnecessary files * fix: use pkg_tar from rules_pkg (#1303) * chore: Fix pre-commit. (#1294) * chore: update CONTRIBUTING.md (#1346) * fix(deps): update dependency io.grpc:grpc-bom to v1.53.0 (#1345) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-bom](https://togithub.com/grpc/grpc-java) | `1.52.1` -> `1.53.0` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/compatibility-slim/1.52.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-bom/1.53.0/confidence-slim/1.52.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.53.0`](https://togithub.com/grpc/grpc-java/releases/tag/v1.53.0) [Compare Source](https://togithub.com/grpc/grpc-java/compare/v1.52.1...v1.53.0) ##### New Features - googleapis: Allow user set c2p bootstrap config ([#9856](https://togithub.com/grpc/grpc-java/issues/9856)) - xds: Add contain and stringMatcher in `RouteConfiguration` ([#9845](https://togithub.com/grpc/grpc-java/issues/9845)) - core: Add `grpc-previous-rpc-attempts` to the initial response metadata ([#9686](https://togithub.com/grpc/grpc-java/issues/9686)) - servlet: Implement gRPC server as a Servlet ([#8596](https://togithub.com/grpc/grpc-java/issues/8596)) - authz: Implement static authorization server interceptor ([#8934](https://togithub.com/grpc/grpc-java/issues/8934)) ##### Examples - servlet: Add servlet example ([#8596](https://togithub.com/grpc/grpc-java/issues/8596)) ##### Bug Fixes - xds: Update xds error handling logic. Specifically: - When the ads stream is closed only send errors to subscribers that haven't yet gotten results - Timers to detect missing resources don’t start until the adsStream is ready ([#9745](https://togithub.com/grpc/grpc-java/issues/9745)) - Call subscriber onError callback when xds client fails to connect to server ([#9827](https://togithub.com/grpc/grpc-java/issues/9827)) - core: Delay retriable stream master listener close until all sub streams are closed. This fixes the call executor lifecycle and prevents potential `RejectedExecutionException`. ([#9754](https://togithub.com/grpc/grpc-java/issues/9754)) - core: Free unused `MessageProducer` in `RetriableStream` ([#9853](https://togithub.com/grpc/grpc-java/issues/9853)), fixing a Netty buffer memory leak for cancelled RPCs - api: Fail with `NullPointerException` when a Metadata.Marshaller returns null bytes ([#9781](https://togithub.com/grpc/grpc-java/issues/9781)). This would previously cause a `NullPointerException` later during the RPC. Now the return value of the Marshaller is checked immediately, to help find the broken Marshaller ##### Behavior Changes - xds: Disallow duplicate addresses in the RingHashLB. ([#9776](https://togithub.com/grpc/grpc-java/issues/9776)) - xds: EDS weight sums are allowed up to max unsigned int (was max signed int) ([#9765](https://togithub.com/grpc/grpc-java/issues/9765)) - xds: Drop xds v2 support ([#9760](https://togithub.com/grpc/grpc-java/issues/9760)) ##### Dependencies - JUnit upgraded to 4.13.2 - bazel: Dropped support for Bazel 4. We track the two most recent major versions of Bazel, Bazel 5 and 6. Bazel 4 may still work, but we are no longer testing it - bazel: Include Tomcat annotations dependency for `@Generated` as used by autovalue ([#9762](https://togithub.com/grpc/grpc-java/issues/9762)). Necessary for building xds and rls on Java 9+ - bazel: Export deps from Maven Central-specific stand-in targets ([#9780](https://togithub.com/grpc/grpc-java/issues/9780)). Some Maven Central artifacts are a combination of multiple Bazel targets, like grpc-core is composed of //core:inprocess, //core:internal, //core:util, //api. There is a “//core:core_maven” target used by maven_install that uses the other targets. Previously the target used `runtime_deps` to discourage their use by Bazel users, but that could cause compilation failures from lack of hjars. These targets now use `exports` ##### Acknowledgement [@cpovirk](https://togithub.com/cpovirk) [@niloc132](https://togithub.com/niloc132) [@stephenh](https://togithub.com/stephenh) [@olderwei](https://togithub.com/olderwei) [@pandaapo](https://togithub.com/pandaapo) [@panxuefeng](https://togithub.com/panxuefeng) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  * chore(deps): update dependency org.apache.maven.plugins:maven-deploy-plugin to v3.1.0 (#1340) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `3.0.0` -> `3.1.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/compatibility-slim/3.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.1.0/confidence-slim/3.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  * chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.0.0-m9 (#1350) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-surefire-plugin](https://maven.apache.org/surefire/) | `3.0.0-M8` -> `3.0.0-M9` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/compatibility-slim/3.0.0-M8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-surefire-plugin/3.0.0-M9/confidence-slim/3.0.0-M8)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-java).  * chore: add rules_pkg to renovate bot ignoreDeps (#1349) Following up on https://togithub.com/googleapis/gapic-generator-java/pull/1338, suppressing renovate PRs for the `rules_pkg` dependency since it will need to align with version used in googleapis. * chore: fix renovate bot ignoreDeps (#1353) Fixes #1352, from missed separator in #1349's changes. * fix(batcher): exceptions in unaryCaller bubble up (#1166) Co-authored-by: Blake Li <blakeli@google.com> * fix(deps): update dependency com.google.auth:google-auth-library-bom to v1.16.0 (#1355) * chore(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.5.0 (#1356) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.1` -> `3.5.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/compatibility-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/confidence-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-java).  * chore(main): release 2.15.1 (#1339) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Emily Wang <emmwang@google.com> * chore: refactoring README and DEVELOPMENT.md (#1351) Thank you for opening a Pull Request! For general contributing guidelines, please refer to [contributing guide](https://togithub.com/googleapis/gapic-generator-java/blob/main/CONTRIBUTING.md) - The old file https://togithub.com/googleapis/gapic-generator-java/blob/main/gapic-generator-java/DEVELOPMENT.md was last touched in mid December. I'm replacing the content with the latest at the root. - Removing the root DEVELOPMENT.md in favor of the file above. - Adding index of the modules at the root README.md - Moving showcase testing guide to showcase/README.md. * chore(main): release 2.15.2-SNAPSHOT (#1358) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: renovate to group Protobuf artifacts (#1362) Copying packageGroup configuration from https://togithub.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/java_library/renovate.json This should avoid separate pull requests for Protobuf: https://togithub.com/googleapis/gapic-generator-java/pull/1155 and https://togithub.com/googleapis/gapic-generator-java/pull/1154 * chore: README.md to explain service_config.proto (#1361) * chore: README.md to explain service_config.proto * add link * chore: Telling owlbot to ignore these files & it's a monorepo (#1372) * chore: Telling owlbot to ignore these files & it's a monorepo * fix: Change the default scope of gax from implementation to api in auto-generated gradle files for self-service client libraries. (#1374) * chore: Update variable name * chore: Fix format issues * fix: Use HttpRule as Value for Custom Bindings * fix: Use HttpRule as Value for Custom Bindings * chore: Add comments * chore: Update tests * fix(deps): update dependency com.google.auth:google-auth-library-bom to v1.15.0 (#1278) * doc: Update DEVELOPMENT.md for local development. (#1237) * chore: Add tests * chore: Cleanup files * chore: Format the files * chore: Add NoCredentialsProvider * chore: Fix sonar comments * chore: Add serviceyaml file for parsing for rest showcase tests * chore: Use service yaml file in test * chore: Fix Echo showcase test * chore: Clean up tests * chore: Sort the map entry to get a consistent ordering for the test * chore: Update showcase and integration tests * chore: Resolve sonar comments * chore: Update comments * chore: Remove a few public constructors * chore: test ci * chore: Remove the cache for java 8 * chore: Update from PR feedback * chore: Update comments * chore: Fix sonar issue * chore: Fix comment * chore: Update to have multiple additional_bindings * chore: Update grpcrest golden test to include httprule * chore: HttpJsonOperationsStub's MethodDescriptors are not static * chore: Add unit tests for HttpJson Operations logic * chore: Resolve lint issues * chore: Clean up test code * chore: Resolve pr comments * chore: Add VisibleForTesting annotation --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Blake Li <blakeli@google.com> Co-authored-by: Mike Eltsufin <meltsufin@google.com> Co-authored-by: Tomo Suzuki <suztomo@gmail.com> Co-authored-by: Mridula <66699525+mpeddada1@users.noreply.github.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Deepankar Dixit <90280028+ddixit14@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com> Co-authored-by: Emily Wang <emmwang@google.com> Co-authored-by: Diego Alonso Marquez Palacios <diegomarquezp@google.com>

Fix pre-commit.

0308c16

blakeli0 requested a review from a team as a code owner February 3, 2023 22:36

blakeli0 requested review from suztomo, burkedavison and meltsufin February 3, 2023 22:53

lqiu96 approved these changes Feb 8, 2023

View reviewed changes

Merge branch 'main' into update_pre_commit

2315d75

product-auto-label bot added the size: s Pull request size is small. label Feb 9, 2023

blakeli0 merged commit 53db0cb into main Feb 10, 2023

blakeli0 deleted the update_pre_commit branch February 10, 2023 19:18

lqiu96 pushed a commit that referenced this pull request Feb 23, 2023

chore: Fix pre-commit. (#1294)

5af299d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Fix pre-commit. #1294

chore: Fix pre-commit. #1294

blakeli0 commented Feb 3, 2023 •

edited

Loading

conventional-commit-lint-gcf bot commented Feb 3, 2023 •

edited

Loading

lqiu96 commented Feb 7, 2023

blakeli0 commented Feb 7, 2023

lqiu96 commented Feb 7, 2023 •

edited

Loading

lqiu96 commented Feb 8, 2023 •

edited

Loading

sonarcloud bot commented Feb 9, 2023

chore: Fix pre-commit. #1294

chore: Fix pre-commit. #1294

Conversation

blakeli0 commented Feb 3, 2023 • edited Loading

conventional-commit-lint-gcf bot commented Feb 3, 2023 • edited Loading

lqiu96 commented Feb 7, 2023

blakeli0 commented Feb 7, 2023

lqiu96 commented Feb 7, 2023 • edited Loading

lqiu96 commented Feb 8, 2023 • edited Loading

sonarcloud bot commented Feb 9, 2023

blakeli0 commented Feb 3, 2023 •

edited

Loading

conventional-commit-lint-gcf bot commented Feb 3, 2023 •

edited

Loading

lqiu96 commented Feb 7, 2023 •

edited

Loading

lqiu96 commented Feb 8, 2023 •

edited

Loading