Skip to content

Commit df14ba8

Browse files
authored
[ggj][ast][engx] fix: validate non-null elements for SynchronizedStatement (#465)
* fix: swap assertEquals args in JavaWriterVisitorTest to match (expected, actusl) order * fix: swap assertEquals args in ImportWriterVisitorTest to match (expected, actusl) order * fix: add node validator to refactor/centralize null element checks * fix: validate non-null elements for IfStatement * fix: validate non-null elements for AnonymousClassExpr * fix: validate non-null elements for BlockStatement * fix: validate non-null elements for ClassDefinition * fix: validate non-null elements for ConcreteReference * fix: validate non-null elements for ForStatement * fix: validate non-null elements for GeneralForStatement * fix: validate non-null elements for MethodDefinition * fix: validate non-null elements for PackageInfoDefinition * fix: validate non-null elements for SynchronizedStatement
1 parent 97caddc commit df14ba8

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/main/java/com/google/api/generator/engine/ast/SynchronizedStatement.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,14 @@ public Builder setBody(Statement... statements) {
6060
// Private.
6161
abstract Builder setLock(Expr expr);
6262

63-
public abstract SynchronizedStatement build();
63+
abstract ImmutableList<Statement> body();
64+
65+
abstract SynchronizedStatement autoBuild();
66+
67+
public SynchronizedStatement build() {
68+
NodeValidator.checkNoNullElements(body(), "body statements", "synchronized statement");
69+
70+
return autoBuild();
71+
}
6472
}
6573
}

0 commit comments

Comments
 (0)