-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: identify and silence owl-bot post-processor failures when PRs attempt to push to a branch on which the post-processor has already run #2307
Comments
cc @parthea |
@parthea brought up in the meeting that the user facing nuisance that arrises as a result of this, is this:
The user facing aspect is the failure that is displayed until the second post processor completes. If an actual fix for this problem is too difficult, one potential stop gap would be putting the OwlBot status back into a pending state, whenever a new post processor run starts. |
I'd like to bump the priority on this issue as it's preventing python from adding owlbot as a required check. I had to manually add the owlbot:run label to trigger owlbot to run again after a push failure. See googleapis/python-api-core#259 |
@danielbankhead are you looking into this one? If not, I'll reassign as it's now 🚨 |
I should be able to get to this by Friday - feel free to grab if you'd like |
The first solution I'd try is to perform a
It will only succeed if there are no conflicts, but if there are conflicts, the PR will need human attention anyway and failure is a good signal. |
I am still seeing these errors in our post-processor: Although it has been greatly reduced! |
See #2304 and #2306
This happens when a PR is created, then the post-processor runs on it, then the PR author attempts to push another commit to that branch without first pulling down the changes. However, ultimately, the post-processor runs fine on Github since the user can force-push in order to retrigger the post-processor. So, perhaps there is a way of silencing these errors, or perhaps a way of delaying the post-processor for a few seconds to ensure another commit pushed to that branch recently does not cause this error.
The text was updated successfully, but these errors were encountered: