-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-please bot is attempting the release of same version after every new merge #988
Comments
We don't currently support pre-releases with the format
Is |
@chingor13 @joeldodge79 another need for a custom version bumping strategy? |
Probably. This is related to @parthea's feature request and requires thought about how to signal the version bump. How do we signal whether the next version should be 1.0.0b2, 1.1.0b1, 1.0.0 or 1.1.0? |
@bcoe PEP 440 describes @chingor13 I would expect that |
@vi3k6i5 I believe this should be corrected now, I believe before the fix this PR would have contained all changes since last non alpha or beta release: |
release-please had to be rolled back due to an unrelated issue, I will close this issue once we re-land. |
fix has been redeployed. |
After every PR merge on github repo release-please bot is trying to do a release of an already released version.
Example:
Successful release of 2.2.1b2 : googleapis/python-spanner-django#687
still reattempted by bot:
googleapis/python-spanner-django#689
googleapis/python-spanner-django#690
Any idea what is causing this and how to resolve it ?
There is a whole list with 2.2.1b1 https://github.com/googleapis/python-spanner-django/pulls?q=is%3Apr+is%3Aclosed
Environment details
release-please
version: latest in productionSteps to reproduce
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!
The text was updated successfully, but these errors were encountered: