Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for maybe_fail_import() #44

Closed
plamut opened this issue Jul 9, 2021 · 1 comment
Closed

Add tests for maybe_fail_import() #44

plamut opened this issue Jul 9, 2021 · 1 comment
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link

plamut commented Jul 9, 2021

Context: googleapis/google-cloud-python#8840 (comment)

Refactoring the utility required a bit more work than it ideally should, thus we should cover it with tests.
@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Jul 9, 2021
@plamut plamut mentioned this issue Jul 9, 2021
Merged
@parthea
Copy link
Contributor

parthea commented Feb 26, 2022

I'm going to close this as a duplicate of googleapis/google-cloud-python#12039

@parthea parthea closed this as completed Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plamut @parthea