-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add blobs retention policy discarding into TestRetentionPolicy… #99
tests: add blobs retention policy discarding into TestRetentionPolicy… #99
Conversation
I've tried to avoid as much requests to the service as I could, so here is how it's gonna work: Every We're adding blob into list after instancing. If test passed, we're calling |
self.assertIsNone(other.retention_expiration_time) | ||
self.assertFalse(blob.event_based_hold) | ||
self.assertFalse(blob.temporary_hold) | ||
self.assertIsNone(blob.retention_expiration_time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, there is an error here: other
blob is already deleted (line 1806). Most likely, blob
was going to be here, as it's just has been uploaded and there is no asserts for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IlyaFaer LGTM
self.assertIsNone(other.retention_expiration_time) | ||
self.assertFalse(blob.event_based_hold) | ||
self.assertFalse(blob.temporary_hold) | ||
self.assertIsNone(blob.retention_expiration_time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
googleapis#99) * tests: add blobs retention policy discarding into TestRetentionPolicy() teardown * merging error fix
googleapis#99) * tests: add blobs retention policy discarding into TestRetentionPolicy() teardown * merging error fix
Closes #97