feat: Integrate google-resumable-media (#1283) #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate the google-resumable-media library into python-storage. --------- Co-authored-by: cojenco <cathyo@google.com>
product-auto-label
bot
added
size: l
andrewsg
changed the title
ddelgrosso1
reviewed
Dec 5, 2024
|
No real comments as this looks like mainly a large refactor to move media internal. Most changes look like just updates to pathing / imports. |
|
Oh I forgot about our earlier review, thanks for reminding me. Okay, I'll merge this and also the later fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the google-resumable-media library into python-storage.
This branch, 3.0-pre, will reconstruct the 3.0-devel branch rebased on top of the most HEAD in main, in preparation for an imminent preview release.
This PR intentionally separates out and skips the intermediate commit move resumable media files into branch without other changes in order to provide a useful diff.
Due to the development process for the 3.0 branch, this PR is being reviewed belatedly as further changes are already integrated on the 3.0-devel branch.
BEGIN_COMMIT_OVERRIDE
feat!: Integrate google-resumable-media
END_COMMIT_OVERRIDE