Skip to content

Commit eae9ebe

Browse files
authored
fix: fix typo in Bucket.clear_lifecycle_rules() (#1169)
Fixes #1074 🦕
1 parent eac91cb commit eae9ebe

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

google/cloud/storage/bucket.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2275,14 +2275,18 @@ def lifecycle_rules(self, rules):
22752275
rules = [dict(rule) for rule in rules] # Convert helpers if needed
22762276
self._patch_property("lifecycle", {"rule": rules})
22772277

2278-
def clear_lifecyle_rules(self):
2278+
def clear_lifecycle_rules(self):
22792279
"""Clear lifecycle rules configured for this bucket.
22802280
22812281
See https://cloud.google.com/storage/docs/lifecycle and
22822282
https://cloud.google.com/storage/docs/json_api/v1/buckets
22832283
"""
22842284
self.lifecycle_rules = []
22852285

2286+
def clear_lifecyle_rules(self):
2287+
"""Deprecated alias for clear_lifecycle_rules."""
2288+
return self.clear_lifecycle_rules()
2289+
22862290
def add_lifecycle_delete_rule(self, **kw):
22872291
"""Add a "delete" rule to lifecycle rules configured for this bucket.
22882292

tests/unit/test_bucket.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2448,6 +2448,7 @@ def test_clear_lifecycle_rules(self):
24482448
bucket._properties["lifecycle"] = {"rule": rules}
24492449
self.assertEqual(list(bucket.lifecycle_rules), rules)
24502450

2451+
# This is a deprecated alias and will test both methods
24512452
bucket.clear_lifecyle_rules()
24522453

24532454
self.assertEqual(list(bucket.lifecycle_rules), [])

0 commit comments

Comments
 (0)