coverage passes

Author: andrewsg

google/cloud/storage/_media/requests/download.py

@@ -140,6 +140,7 @@ def _write_to_stream(self, response):
                 )
                 raise DataCorruption(response, msg)
 
+
     def consume(
         self,
         transport,

tests/resumable_media/unit/requests/test_download.py

@@ -52,6 +52,25 @@ def test__write_to_stream_no_hash_check(self):
             chunk_size=_request_helpers._SINGLE_GET_CHUNK_SIZE, decode_unicode=False
         )
 
+    def test__write_to_stream_empty_chunks(self):
+        stream = io.BytesIO()
+        download = download_mod.Download(EXAMPLE_URL, stream=stream)
+
+        response = _mock_response(chunks=[], headers={})
+
+        ret_val = download._write_to_stream(response)
+        assert ret_val is None
+
+        assert stream.getvalue() == b""
+        assert download._bytes_downloaded == 0
+
+        # Check mocks.
+        response.__enter__.assert_called_once_with()
+        response.__exit__.assert_called_once_with(None, None, None)
+        response.iter_content.assert_called_once_with(
+            chunk_size=_request_helpers._SINGLE_GET_CHUNK_SIZE, decode_unicode=False
+        )
+
     @pytest.mark.parametrize("checksum", ["md5", "crc32c", None])
     def test__write_to_stream_with_hash_check_success(self, checksum):
         stream = io.BytesIO()
@@ -1156,11 +1175,11 @@ def test_decompress(self):
         md5_hash.update.assert_called_once_with(data)
 
 
-def _mock_response(status_code=http.client.OK, chunks=(), headers=None):
+def _mock_response(status_code=http.client.OK, chunks=None, headers=None):
     if headers is None:
         headers = {}
 
-    if chunks:
+    if chunks is not None:
         mock_raw = mock.Mock(headers=headers, spec=["headers"])
         response = mock.MagicMock(
             headers=headers,

tests/unit/test_exceptions.py

@@ -0,0 +1,67 @@
+# Copyright 2024 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from importlib import reload
+from unittest.mock import Mock
+import sys
+
+def test_exceptions_imports_correctly_in_base_case():
+    try:
+        mock = Mock(spec=[])
+        sys.modules['google.resumable_media'] = mock
+
+        from google.cloud.storage import exceptions
+        reload(exceptions)
+        invalid_response = exceptions.InvalidResponse(Mock())
+        ir_base_names = [base.__name__ for base in invalid_response.__class__.__bases__]
+        assert ir_base_names == ["Exception"]
+
+        data_corruption = exceptions.DataCorruption(Mock())
+        dc_base_names = [base.__name__ for base in data_corruption.__class__.__bases__]
+        assert dc_base_names == ["Exception"]
+    finally:
+        del sys.modules['google.resumable_media']
+        reload(exceptions)
+
+def test_exceptions_imports_correctly_in_resumable_media_installed_case():
+    try:
+        mock = Mock(spec=["InvalidResponse", "DataCorruption"])
+
+        class InvalidResponse(Exception):
+            def __init__(self, response, *args):
+                super().__init__(*args)
+                self.response = response
+
+        class DataCorruption(Exception):
+            def __init__(self, response, *args):
+                super().__init__(*args)
+                self.response = response
+
+        mock.InvalidResponse = InvalidResponse
+        mock.DataCorruption = DataCorruption
+
+        sys.modules['google.resumable_media'] = mock
+
+        from google.cloud.storage import exceptions
+        reload(exceptions)
+        invalid_response = exceptions.InvalidResponse(Mock())
+        ir_base_names = [base.__name__ for base in invalid_response.__class__.__bases__]
+        assert ir_base_names == ["InvalidResponse"]
+
+        data_corruption = exceptions.DataCorruption(Mock())
+        dc_base_names = [base.__name__ for base in data_corruption.__class__.__bases__]
+        assert dc_base_names == ["DataCorruption"]
+    finally:
+        del sys.modules['google.resumable_media']
+        reload(exceptions)