Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_retention_period): Changes to backup.create API to suppo… #961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

satyaprakashg
Copy link

…rt null expire time

With the default retention period feature, null value for expiration time is a valid value. If the expiration time is not specified (null) at the time of create backup then the backup will be retained for the duration of maximum retention period.

In this commit, the precondition check on expiration time in the create backup API path is removed. The condition remains intact for copy backup API and that would be addressed in a follow-up commit.

Fixes #288359014

@satyaprakashg satyaprakashg requested review from a team as code owners June 22, 2023 08:21
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Jun 22, 2023
@satyaprakashg
Copy link
Author

@asthamohta Could you please review this diff. Also, can you add a "do not merge" tag on this diff since the backend changes aren't merged yet.

…rt null expire time

With the default retention period feature, null value for expiration time
is a valid value. If the expiration time is not specified (null) at the
time of create backup then the backup will be retained for the duration
of maximum retention period.

In this commit, the precondition check on expiration time in the create
backup API path is removed. The condition remains intact for copy backup
API and that would be addressed in a follow-up commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants