Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for updateDatabase in Cloud Spanner #914

Merged
merged 14 commits into from
May 16, 2023
Merged

feat: add support for updateDatabase in Cloud Spanner #914

merged 14 commits into from
May 16, 2023

Conversation

aayushimalik
Copy link
Contributor

No description provided.

@aayushimalik aayushimalik requested review from a team as code owners March 16, 2023 11:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Mar 16, 2023
grace223
grace223 approved these changes Mar 18, 2023
View reviewed changes
google/cloud/spanner_v1/database.py
@@ -29,6 +29,7 @@
from google.api_core import gapic_v1
from google.iam.v1 import iam_policy_pb2
from google.iam.v1 import options_pb2
from google.protobuf.field_mask_pb2 import FieldMask

from google.cloud.spanner_admin_database_v1 import CreateDatabaseRequest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

tests/unit/test_database.py
@@ -17,8 +17,10 @@

import mock
from google.api_core import gapic_v1
from google.cloud.spanner_admin_database_v1 import Database as DatabasePB
from google.cloud.spanner_v1.param_types import INT64
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aayushimalik aayushimalik requested a review from a team as a code owner March 21, 2023 09:49
@aayushimalik aayushimalik requested a review from parthea March 21, 2023 09:49
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 21, 2023
@snippet-bot
Copy link

snippet-bot bot commented Mar 21, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@aayushimalik aayushimalik force-pushed the drop-database-protection branch from 9ca2103 to e4163d0 Compare March 21, 2023 10:26
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Mar 21, 2023
@rajatbhatta rajatbhatta changed the title feat: drop database protection feat: add support for updateDatabase in Cloud Spanner Apr 4, 2023
@rajatbhatta rajatbhatta requested a review from asthamohta April 4, 2023 17:21
asthamohta
asthamohta reviewed Apr 21, 2023
View reviewed changes
google/cloud/spanner_v1/database.py
@@ -155,6 +160,8 @@ def __init__(
self._encryption_config = encryption_config
self._database_dialect = database_dialect
self._database_role = database_role
self._enable_drop_protection = enable_drop_protection
self._reconciling = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any place where this value is updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updated at line 359 of this file, using the property setter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am referring to reconciling

@asthamohta asthamohta added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 26, 2023
@rajatbhatta rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2023
@rajatbhatta rajatbhatta enabled auto-merge (squash) May 16, 2023 06:24
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@rajatbhatta
Copy link
Contributor

Added samples from #917 to here (for single merge). Both PRs are approved.

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@rajatbhatta rajatbhatta merged commit 6c7ad29 into googleapis:main May 16, 2023
@release-please release-please bot mentioned this pull request May 16, 2023
Merged
@rajatbhatta rajatbhatta mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta left review comments

@grace223 grace223 grace223 approved these changes

@asthamohta asthamohta asthamohta approved these changes

@parthea parthea Awaiting requested review from parthea parthea is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aayushimalik @rajatbhatta @asthamohta @grace223 @yoshi-kokoro