Skip to content

chore: run backup tests #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2022
Merged

chore: run backup tests #753

merged 1 commit into from
Jun 29, 2022

Conversation

ansh0l
Copy link
Contributor

@ansh0l ansh0l commented Jun 19, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ansh0l ansh0l requested review from a team as code owners June 19, 2022 19:48
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Jun 19, 2022
@asthamohta asthamohta merged commit c077480 into googleapis:main Jun 29, 2022
alkatrivedi pushed a commit to alkatrivedi/python-spanner that referenced this pull request Jun 29, 2022
@ansh0l @alkatrivedi
chore: correct skip backup tests env variable (googleapis#753)
9c72631
alkatrivedi pushed a commit to alkatrivedi/python-spanner that referenced this pull request Jun 29, 2022
@ansh0l @alkatrivedi
chore: correct skip backup tests env variable (googleapis#753)
5fc5b30
asthamohta pushed a commit to asthamohta/python-spanner that referenced this pull request Jun 29, 2022
@ansh0l @asthamohta
chore: correct skip backup tests env variable (googleapis#753)
b286389
asthamohta added a commit that referenced this pull request Jul 5, 2022
@asthamohta @ansh0l
test: postgresql tests fix (#759)
18c4f1f 
* changes for testing in postgres

* parametrized testing

* parametrized testing

* chore: correct skip backup tests env variable (#753)

* increasing timeout

* splitting tests

* changes as per review

* Revert "changes as per review"

This reverts commit 63064c7.

* Revert "splitting tests"

This reverts commit ae49fde.

* skipping backup testing

Co-authored-by: ansh0l <ansh0l@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ansh0l @rajatbhatta @asthamohta