Skip to content

refactor: erase SQL statements parsing #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 30, 2022
Merged

refactor: erase SQL statements parsing #679

merged 8 commits into from
May 30, 2022

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Feb 8, 2022 •
edited
Loading

Continuation of an older PR: #630
All the errors fixed.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 8, 2022
@IlyaFaer IlyaFaer marked this pull request as ready for review February 10, 2022 14:04
@IlyaFaer IlyaFaer requested review from a team as code owners February 10, 2022 14:04
@IlyaFaer IlyaFaer requested a review from vi3k6i5 February 10, 2022 14:04
@IlyaFaer IlyaFaer mentioned this pull request Feb 11, 2022
Closed
larkee
larkee reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one unresolved comment from the previous PR 👍

@asthamohta asthamohta requested review from larkee and removed request for vi3k6i5 May 18, 2022 13:36
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 24, 2022
asthamohta
asthamohta approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the unresolved comment by Skylar

@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2022
@asthamohta asthamohta merged commit 29b99d9 into googleapis:main May 30, 2022
@IlyaFaer IlyaFaer deleted the db_api_refactor branch May 30, 2022 09:42
@c2nes c2nes mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asthamohta asthamohta asthamohta approved these changes

@larkee larkee Awaiting requested review from larkee

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IlyaFaer @larkee @asthamohta @yoshi-kokoro