Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add constraints file #203

Merged
merged 6 commits into from
Jan 7, 2021
Merged

chore: add constraints file #203

merged 6 commits into from
Jan 7, 2021

Conversation

busunkim96
Copy link
Contributor

Add constraints file to test lower bounds. These files will not be used until the noxfile is changed in googleapis/synthtool#869.

@busunkim96 busunkim96 requested a review from a team as a code owner December 30, 2020 20:57
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Dec 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
@busunkim96 busunkim96 changed the title chore: add comnstraints file chore: add constraints file Dec 30, 2020
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but how come there's only a constraints file for 3.6? This project uses 3.8 as the default for tests, and doesn't run any tests for python versions >3.8.

Maybe a problem for another PR, but since the constraints files are just mechanically built from the requirements in setup.py, could synthtool keep the constraints files up to date instead of doing this manually?

@busunkim96
Copy link
Contributor Author

Looks fine to me, but how come there's only a constraints file for 3.6? This project uses 3.8 as the default for tests, and doesn't run any tests for python versions >3.8.

Hey Chris! Right now the unit and system tests in the libraries always fetch the latest versions of dependencies. It's led to a few instances where we forgot to bump the minimum required version of some dependency (google-api-core for example). The idea is to test the lower bound in one of the test sessions (3.6 was chosen arbitrarily). We also want to continue to make sure the library works with the latest versions of the dependencies. When the constraints file is empty, the latest versions will be installed. If I'm reading the noxfile correctly it looks like unit tests run for 3.6, 3.7, and 3.8. I added future python versions pre-emptively to reduce noise when the new versions come out.

Maybe a problem for another PR, but since the constraints files are just mechanically built from the requirements in setup.py, could synthtool keep the constraints files up to date instead of doing this manually?

That's a fair point, it would be nice if this were more automated. I've opened googleapis/google-cloud-python#10521 to track that.

@busunkim96 busunkim96 merged commit 4a58bcb into master Jan 7, 2021
@c24t c24t deleted the add-constraints-file branch January 29, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants