feat: Add support for multiplexed sessions - part 4a (precommit tokens) #1374
+1,171
−795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
currantw
commented
May 9, 2025
Comment on lines
+773
to
+788
| def session(self, labels=None, database_role=None): | ||
| """Deprecated. Factory to create a session for this database. | ||
|
|
||
| :type labels: dict (str -> str) or None | ||
| :param labels: (Optional) user-assigned labels for the session. | ||
|
|
||
| :type database_role: str | ||
| :param database_role: (Optional) user-assigned database_role for the session. | ||
|
|
||
| :rtype: :class:`~google.cloud.spanner_v1.session.Session` | ||
| :returns: a session bound to this database. | ||
| """ | ||
| # If role is specified in param, then that role is used | ||
| # instead. | ||
| role = database_role or self._database_role | ||
| return Session(self, labels=labels, database_role=role) |
There was a problem hiding this comment.
Method is deprecated and should be removed.
currantw
commented
May 9, 2025
| @@ -34,7 +33,7 @@ class StreamedResultSet(object): | |||
| instances. | |||
|
|
|||
| :type source: :class:`~google.cloud.spanner_v1.snapshot.Snapshot` | |||
| :param source: Snapshot from which the result set was fetched. | |||
| :param source: Deprecated. Snapshot from which the result set was fetched. | |||
There was a problem hiding this comment.
Deprecated. No longer used or needed.
- Add ingest of precommit tokens - Add precommit tokens to commit request Signed-off-by: currantw <taylor.curran@improving.com>
currantw
force-pushed
the
multiplexed_sessions_4
branch
from
f943cee to
1722339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add support for multiplexed sessions - part 4a (precommit tokens)
- Add ingest of precommit tokens
- Add precommit tokens to commit request