Skip to content

Commit 01d3b06

Browse files
authored
samples: parameterises create backup version time (#249)
1 parent f984b26 commit 01d3b06

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

samples/samples/backup_sample.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,12 @@
2626

2727

2828
# [START spanner_create_backup]
29-
def create_backup(instance_id, database_id, backup_id):
29+
def create_backup(instance_id, database_id, backup_id, version_time):
3030
"""Creates a backup for a database."""
3131
spanner_client = spanner.Client()
3232
instance = spanner_client.instance(instance_id)
3333
database = instance.database(database_id)
3434

35-
# Sets the version time as the current server time
36-
version_time = None
37-
with database.snapshot() as snapshot:
38-
results = snapshot.execute_sql("SELECT CURRENT_TIMESTAMP()")
39-
version_time = list(results)[0][0]
40-
4135
# Create a backup
4236
expire_time = datetime.utcnow() + timedelta(days=14)
4337
backup = instance.backup(backup_id, database=database, expire_time=expire_time, version_time=version_time)

samples/samples/backup_sample_test.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@ def database(spanner_instance):
6767

6868

6969
def test_create_backup(capsys, database):
70-
backup_sample.create_backup(INSTANCE_ID, DATABASE_ID, BACKUP_ID)
70+
version_time = None
71+
with database.snapshot() as snapshot:
72+
results = snapshot.execute_sql("SELECT CURRENT_TIMESTAMP()")
73+
version_time = list(results)[0][0]
74+
75+
backup_sample.create_backup(INSTANCE_ID, DATABASE_ID, BACKUP_ID, version_time)
7176
out, _ = capsys.readouterr()
7277
assert BACKUP_ID in out
7378

0 commit comments

Comments
 (0)