Skip to content

Commit 8fae358

Browse files
authored
fix: Fix check so it's all lowercase. (#321)
Fixes #319 - [x] Tests pass - [x] Appropriate changes to README are included in PR
1 parent b80d24d commit 8fae358

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ class SpannerIdentifierPreparer(IdentifierPreparer):
182182

183183
reserved_words = RESERVED_WORDS.copy()
184184
reserved_words.update(spanner_dbapi.parse_utils.SPANNER_RESERVED_KEYWORDS)
185+
reserved_words_lc = set(map(str.lower, reserved_words))
185186

186187
def __init__(self, dialect):
187188
super(SpannerIdentifierPreparer, self).__init__(
@@ -195,7 +196,7 @@ def _requires_quotes(self, value):
195196
return False
196197

197198
return (
198-
lc_value in self.reserved_words
199+
lc_value in self.reserved_words_lc
199200
or value[0] in self.illegal_initial_characters
200201
or not self.legal_characters.match(str(value))
201202
or (lc_value != value)

0 commit comments

Comments
 (0)