Skip to content

Commit 8379c74

Browse files
committed
chore: remove GetSession requests
1 parent 65d7d3b commit 8379c74

File tree

1 file changed

+10
-17
lines changed

1 file changed

+10
-17
lines changed

test/mockserver_tests/test_stale_reads.py

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
FixedSizePool,
2121
BatchCreateSessionsRequest,
2222
ExecuteSqlRequest,
23-
GetSessionRequest,
2423
BeginTransactionRequest,
2524
TransactionOptions,
2625
)
@@ -55,19 +54,16 @@ def test_stale_read_multi_use(self):
5554

5655
# Verify the requests that we got.
5756
requests = self.spanner_service.requests
58-
eq_(9, len(requests))
57+
eq_(7, len(requests))
5958
is_instance_of(requests[0], BatchCreateSessionsRequest)
60-
# We should get rid of this extra round-trip for GetSession....
61-
is_instance_of(requests[1], GetSessionRequest)
62-
is_instance_of(requests[2], BeginTransactionRequest)
59+
is_instance_of(requests[1], BeginTransactionRequest)
60+
is_instance_of(requests[2], ExecuteSqlRequest)
6361
is_instance_of(requests[3], ExecuteSqlRequest)
64-
is_instance_of(requests[4], ExecuteSqlRequest)
65-
is_instance_of(requests[5], GetSessionRequest)
66-
is_instance_of(requests[6], BeginTransactionRequest)
67-
is_instance_of(requests[7], ExecuteSqlRequest)
68-
is_instance_of(requests[8], ExecuteSqlRequest)
62+
is_instance_of(requests[4], BeginTransactionRequest)
63+
is_instance_of(requests[5], ExecuteSqlRequest)
64+
is_instance_of(requests[6], ExecuteSqlRequest)
6965
# Verify that the transaction is a read-only transaction.
70-
for index in [2, 6]:
66+
for index in [1, 4]:
7167
begin_request: BeginTransactionRequest = requests[index]
7268
eq_(
7369
TransactionOptions(
@@ -105,15 +101,12 @@ def test_stale_read_single_use(self):
105101

106102
# Verify the requests that we got.
107103
requests = self.spanner_service.requests
108-
eq_(5, len(requests))
104+
eq_(3, len(requests))
109105
is_instance_of(requests[0], BatchCreateSessionsRequest)
110-
# We should get rid of this extra round-trip for GetSession....
111-
is_instance_of(requests[1], GetSessionRequest)
106+
is_instance_of(requests[1], ExecuteSqlRequest)
112107
is_instance_of(requests[2], ExecuteSqlRequest)
113-
is_instance_of(requests[3], GetSessionRequest)
114-
is_instance_of(requests[4], ExecuteSqlRequest)
115108
# Verify that the requests use a stale read.
116-
for index in [2, 4]:
109+
for index in [1, 2]:
117110
execute_request: ExecuteSqlRequest = requests[index]
118111
eq_(
119112
TransactionOptions(

0 commit comments

Comments
 (0)