Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add constraints file #272

Merged
merged 6 commits into from
Mar 5, 2021
Merged

Conversation

busunkim96
Copy link
Contributor

Add constraints file to test lower bounds. These files will not be used until the noxfile is changed in googleapis/synthtool#869.

@busunkim96 busunkim96 requested a review from a team as a code owner December 30, 2020 20:53
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
@busunkim96 busunkim96 changed the title chore: add comnstraints file chore: add constraints file Dec 30, 2020
@plamut
Copy link
Contributor

plamut commented Mar 5, 2021

@busunkim96 Can you please just rebase or merge master into it to get around the samples tests flakiness that was addressed recently?

@busunkim96 busunkim96 force-pushed the add-constraints-file branch from cc7bc67 to 0f333f4 Compare March 5, 2021 15:27
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2021
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f890d2d into master Mar 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-constraints-file branch March 5, 2021 21:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants