Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typecheck errors in samples/snippets/subscriber.py #1186

Merged
merged 7 commits into from
Jun 7, 2024
Merged

fix: Typecheck errors in samples/snippets/subscriber.py #1186

merged 7 commits into from
Jun 7, 2024

Conversation

mukund-ananthu
Copy link
Contributor

Fix type check errors in the samples/snippets/subscriber.py file.

Fixes #1059 🦕

@mukund-ananthu mukund-ananthu requested review from a team as code owners June 7, 2024 16:11
@mukund-ananthu mukund-ananthu self-assigned this Jun 7, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 7, 2024
@mukund-ananthu
Copy link
Contributor Author

@parthea PTAL when free.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jun 7, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 7, 2024
parthea
parthea approved these changes Jun 7, 2024
View reviewed changes
samples/snippets/mypy.ini Outdated Show resolved Hide resolved
@mukund-ananthu @parthea
Update samples/snippets/mypy.ini
a6fbe99 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@mukund-ananthu mukund-ananthu enabled auto-merge (squash) June 7, 2024 18:28
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthu mukund-ananthu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@mukund-ananthu mukund-ananthu merged commit 3698450 into main Jun 7, 2024
28 checks passed
@mukund-ananthu mukund-ananthu deleted the snippetsTypeFix branch June 7, 2024 20:10
@release-please release-please bot mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@leahecole leahecole Awaiting requested review from leahecole leahecole is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: Module "google.cloud" has no attribute "pubsub_v1"
3 participants
@mukund-ananthu @parthea @yoshi-kokoro