Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher Limit Exceeded Behavior defaults to IGNORE while Java library defaults to BLOCK #1055

Closed
oryband opened this issue Dec 25, 2023 · 2 comments
Assignees
Labels
api: pubsub Issues related to the googleapis/python-pubsub API.

Comments

@oryband
Copy link

oryband commented Dec 25, 2023

The default publisher limit exceeded behavior is inconsistent between Python and Java libraries. Python "silently" skips messages while Java blocks. I'm migrating an application from Java to Python, and I was surprised the behavior to be different. How come? Both libraries use thread pools without async-io (or it's java equivalent). At the very least this inconsistency should be documented and emphasized.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 25, 2023
@mukund-ananthu
Copy link
Contributor

Hi @oryband , looking at the lines you refer to in the post, I see that currently:

  1. Python:
    limit_exceeded_behavior: LimitExceededBehavior = LimitExceededBehavior.IGNORE

  2. Java:

.setFlowControlSettings(
                FlowControlSettings.newBuilder()
                    .setLimitExceededBehavior(FlowController.LimitExceededBehavior.Ignore)
                    .build())

Where both languages have the behavior as ignore. Could you please let me know where you observe this deviation?

@mukund-ananthu
Copy link
Contributor

@oryband , Closing this issue as not reproducible due to the reasons mentioned in #1055 (comment). Please feel free to re-open the issue if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API.
Projects
None yet
Development

No branches or pull requests

3 participants