[DRAFT] Support Json logs #304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
daniel-sanche
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
google-cla
bot
added
the
cla: yes
|
closed in favor of #316. Had to rebase branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full support for JSON logs, along with standard text logs. Now, users can call
logging.error({'a':'b'}), and they will get a JsonPayload in Cloud Logging, Or calllogging.error('test')to receive a TextPayloadAs part of this change, I added a generic
loger.log()function, which serves as a generic entry-point instead oflogger.log_textorlogger.log_struct. It will infer which log function is meant based on the input typePreviously, the library would attach the python logger name as part of the JSON payload for each log. Now, that information will be attached as a label instead, giving users full control of the log payload fields
Fixes #186, #263, #13