Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds bounds checking because pandas now handles microsecond reso… #166

Merged
merged 2 commits into from
Jan 3, 2023
Merged

fix: adds bounds checking because pandas now handles microsecond reso… #166

merged 2 commits into from
Jan 3, 2023

Conversation

chalmerlowe
Copy link
Collaborator

Fixes #160
Fixes #159
Fixes #158
Fixes #157

🦕

@chalmerlowe chalmerlowe requested a review from a team as a code owner December 21, 2022 13:27
@chalmerlowe chalmerlowe requested review from a team and tswast December 21, 2022 13:27
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Dec 21, 2022
shollyman
shollyman approved these changes Dec 21, 2022
View reviewed changes
Copy link

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, assuming the coverage issue is straightforward to resolve. If you need a followup review let me know.

tswast
tswast reviewed Jan 3, 2023
View reviewed changes
db_dtypes/__init__.py Outdated Show resolved Hide resolved
@chalmerlowe @tswast
Update db_dtypes/__init__.py
27f04c3 
Co-authored-by: Tim Swast <swast@google.com>
@chalmerlowe chalmerlowe merged commit 357a315 into main Jan 3, 2023
@chalmerlowe chalmerlowe deleted the out-of-bounds-validation branch January 3, 2023 15:55
@release-please release-please bot mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
3 participants
@chalmerlowe @tswast @shollyman