fix: respect deadlines for column family operations #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n families As a sideeffect this also fixes a bug where the default deadlines were not applied.
product-auto-label
bot
added
size: s
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
mutianf
approved these changes
Oct 20, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 20, 2022
🤖 I have created a release *beep* *boop* --- ## [2.13.2](https://togithub.com/googleapis/python-bigtable/compare/v2.13.1...v2.13.2) (2022-10-20) ### Bug Fixes * Respect deadlines for column family operations ([#687](https://togithub.com/googleapis/python-bigtable/issues/687)) ([df2e64a](https://togithub.com/googleapis/python-bigtable/commit/df2e64a79bbd8b28d0991706607af99d539320d1)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small fix to specifically address a blocker for a customer. This does not try to address the wider issue of timeouts.
The root of the problem is described here:
googleapis/gapic-generator-python#1477
The tldr is that the default timeouts in base.py are applied by default across all of our RPCs. The only exceptions are ReadRows and MutateRows (and after this PR column operations).
Fixing the broader problem will require coordination with:
googleapis/python-api-core#462
We also need to to flesh out a design for overriding deadlines per method and/or rpc.