feat: Expose remote function options (maxBatchingRows, containerCpu, containerMemory) as first class properties#2305
Closed
chalmerlowe wants to merge 2 commits intomainfrom
Closed
feat: Expose remote function options (maxBatchingRows, containerCpu, containerMemory) as first class properties#2305chalmerlowe wants to merge 2 commits intomainfrom
maxBatchingRows, containerCpu, containerMemory) as first class properties#2305chalmerlowe wants to merge 2 commits intomainfrom
Conversation
Exposes `maxBatchingRows`, `containerCpu`, and `containerMemory` as first-class properties on the `RemoteFunctionOptions` class. Fixes #2240
product-auto-label
bot
added
the
api: bigquery
Collaborator
Author
|
Waiting for a response on the Issue about the intent of the requester. See Issue #2240 |
chalmerlowe
added
the
do not merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE: do not merge. awaiting feedback on the correct location to hang these properties. See convo in #2240
Exposes
maxBatchingRows,containerCpu, andcontainerMemoryas first-class properties on theRemoteFunctionOptionsclass.Fixes #2240 🦕