Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add default_version and codeowner_team to .repo-metadata.json #1001

Merged
merged 5 commits into from
Oct 6, 2021
Merged

chore: add default_version and codeowner_team to .repo-metadata.json #1001

merged 5 commits into from
Oct 6, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 4, 2021

Set codeowner_team to googleapis/api-bigquery as codeowner. Set default_version to v2. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114

@parthea parthea requested a review from a team October 4, 2021 10:33
@parthea parthea requested a review from a team as a code owner October 4, 2021 10:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 4, 2021
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 4, 2021
@tswast
Copy link
Contributor

tswast commented Oct 4, 2021

I don't think the generated index change https://github.com/googleapis/synthtool/pull/1114/files can apply to this repo. services/ and types/ refer to auto-generated code (which we do have some of), but aren't at all the most useful pages to link to. reference.rst has the links to relevant modules.

I'd prefer if this PR excluded index.rst from the owlbot templates.

tswast
tswast requested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switching to request changes due to wanting update to owlbot.py

@parthea parthea self-assigned this Oct 5, 2021
@parthea parthea requested a review from tswast October 5, 2021 15:10
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 6, 2021
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 6, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c6cf0f7 into main Oct 6, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-default-version-codeowner-team-to-repo-metadata branch October 6, 2021 14:56
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 6, 2021
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@parthea @abdelmegahedgoogle
chore: add default_version and codeowner_team to .repo-metadata.json (g…
383be7b 
…oogleapis#1001)

Set codeowner_team to googleapis/api-bigquery as codeowner. Set default_version to v2. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

Assignees

@parthea parthea

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @tswast