Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove date_as_object argument from to_dataframe #861

Closed
tswast opened this issue Aug 6, 2021 · 6 comments
Closed

remove date_as_object argument from to_dataframe #861

tswast opened this issue Aug 6, 2021 · 6 comments
Assignees
@jimfulton
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Aug 6, 2021

I believe this was added to support #11 and #136, but I'm not convinced that this was the right approach. Instead, what we do for TIMESTAMP columns seems more appropriate -- try to cast to the right data type. If it fails due to out-of-range, then fallback to objects.
@tswast tswast added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. semver: major Hint for users that this is an API breaking change. labels Aug 6, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 6, 2021
@tswast tswast self-assigned this Aug 6, 2021
@tswast
Copy link
Contributor Author

tswast commented Aug 9, 2021

Per https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#generating-ranges-of-timestamps

datetime64[ns] is the expected dtype for dates. This is the dtype that is the result of the pandas.date_range function.

@tswast tswast mentioned this issue Aug 12, 2021
Merged
4 tasks
@tswast tswast assigned jimfulton and plamut and unassigned tswast Aug 31, 2021
@plamut
Copy link
Contributor

plamut commented Sep 1, 2021

OK, will remove it.

@jimfulton jimfulton removed their assignment Sep 1, 2021
@tswast tswast mentioned this issue Sep 1, 2021
Closed
@jimfulton
Copy link
Contributor

@plamut have you started on this yet?

I'm running into this as part of my pandas date type. I'd just as soon take this.

@plamut
Copy link
Contributor

plamut commented Sep 15, 2021

@jimfulton Kind of started, but had to switch to other things. If it's a semi-blocker for you that needs to be resolved now-ish, feel free to take it.

@jimfulton jimfulton assigned jimfulton and unassigned plamut Sep 15, 2021
@jimfulton
Copy link
Contributor

Mine! :)

Thanks.

@jimfulton jimfulton mentioned this issue Sep 15, 2021
Merged
4 tasks
@tswast tswast mentioned this issue Sep 22, 2021
Closed
@tswast
Copy link
Contributor Author

tswast commented Dec 1, 2021

Fixed by #972 (to be released in v3)

@tswast tswast closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimfulton jimfulton

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tswast @jimfulton @plamut