Skip to content

Commit 6f11d53

Browse files
feat: remove python 3.8 support
1 parent 5f0bc1f commit 6f11d53

File tree

14 files changed

+13
-127
lines changed

14 files changed

+13
-127
lines changed

.github/sync-repo-settings.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ branchProtectionRules:
1111
- 'OwlBot Post Processor'
1212
- 'Kokoro'
1313
- 'Samples - Lint'
14-
- 'Samples - Python 3.8'
1514
- 'Samples - Python 3.9'
1615
- 'Samples - Python 3.10'
1716
- 'Samples - Python 3.11'

.kokoro/samples/python3.8/common.cfg

Lines changed: 0 additions & 40 deletions
This file was deleted.

.kokoro/samples/python3.8/continuous.cfg

Lines changed: 0 additions & 6 deletions
This file was deleted.

.kokoro/samples/python3.8/periodic-head.cfg

Lines changed: 0 additions & 11 deletions
This file was deleted.

.kokoro/samples/python3.8/periodic.cfg

Lines changed: 0 additions & 6 deletions
This file was deleted.

.kokoro/samples/python3.8/presubmit.cfg

Lines changed: 0 additions & 6 deletions
This file was deleted.

CONTRIBUTING.rst

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ In order to add a feature:
2222
documentation.
2323

2424
- The feature must work fully on the following CPython versions:
25-
3.8, 3.9, 3.10, 3.11, 3.12, and 3.13 on both UNIX and Windows.
25+
3.9, 3.10, 3.11, 3.12, and 3.13 on both UNIX and Windows.
2626

2727
- The feature must not add unnecessary dependencies (where
2828
"unnecessary" is of course subjective, but new dependencies should
@@ -148,7 +148,7 @@ Running System Tests
148148

149149
.. note::
150150

151-
System tests are only configured to run under Python 3.8, 3.12, and 3.13.
151+
System tests are only configured to run under Python 3.12, and 3.13.
152152
For expediency, we do not run them in older versions of Python 3.
153153

154154
This alone will not run the tests. You'll need to change some local
@@ -195,11 +195,11 @@ configure them just like the System Tests.
195195

196196
# Run all tests in a folder
197197
$ cd samples/snippets
198-
$ nox -s py-3.8
198+
$ nox -s py-3.9
199199

200200
# Run a single sample test
201201
$ cd samples/snippets
202-
$ nox -s py-3.8 -- -k <name of test>
202+
$ nox -s py-3.9 -- -k <name of test>
203203

204204
********************************************
205205
Note About ``README`` as it pertains to PyPI
@@ -221,14 +221,12 @@ Supported Python Versions
221221

222222
We support:
223223

224-
- `Python 3.8`_
225224
- `Python 3.9`_
226225
- `Python 3.10`_
227226
- `Python 3.11`_
228227
- `Python 3.12`_
229228
- `Python 3.13`_
230229

231-
.. _Python 3.8: https://docs.python.org/3.8/
232230
.. _Python 3.9: https://docs.python.org/3.9/
233231
.. _Python 3.10: https://docs.python.org/3.10/
234232
.. _Python 3.11: https://docs.python.org/3.11/
@@ -241,7 +239,7 @@ Supported versions can be found in our ``noxfile.py`` `config`_.
241239
.. _config: https://github.com/googleapis/python-bigquery-sqlalchemy/blob/main/noxfile.py
242240

243241

244-
We also explicitly decided to support Python 3 beginning with version 3.8.
242+
We also explicitly decided to support Python 3 beginning with version 3.9.
245243
Reasons for this include:
246244

247245
- Encouraging use of newest versions of Python 3

README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ dependencies.
5151

5252
Supported Python Versions
5353
^^^^^^^^^^^^^^^^^^^^^^^^^
54-
Python >= 3.8, <3.14
54+
Python >= 3.9, <3.14
5555

5656
Unsupported Python Versions
5757
^^^^^^^^^^^^^^^^^^^^^^^^^^^

noxfile.py

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@
3939
"setup.py",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = "3.8"
42+
DEFAULT_PYTHON_VERSION = "3.9"
4343

44-
UNIT_TEST_PYTHON_VERSIONS: List[str] = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
44+
UNIT_TEST_PYTHON_VERSIONS: List[str] = ["3.9", "3.10", "3.11", "3.12", "3.13"]
4545
UNIT_TEST_STANDARD_DEPENDENCIES = [
4646
"mock",
4747
"asyncmock",
@@ -56,11 +56,6 @@
5656
"tests",
5757
]
5858
UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
59-
"3.8": [
60-
"tests",
61-
"alembic",
62-
"bqstorage",
63-
],
6459
"3.11": [
6560
"tests",
6661
"geography",
@@ -78,7 +73,7 @@
7873
],
7974
}
8075

81-
SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.8", "3.12", "3.13"]
76+
SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.12", "3.13"]
8277
SYSTEM_TEST_STANDARD_DEPENDENCIES: List[str] = [
8378
"mock",
8479
"pytest",
@@ -91,11 +86,6 @@
9186
"tests",
9287
]
9388
SYSTEM_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
94-
"3.8": [
95-
"tests",
96-
"alembic",
97-
"bqstorage",
98-
],
9989
"3.12": [
10090
"tests",
10191
"geography",
@@ -398,9 +388,7 @@ def compliance(session):
398388
"-c",
399389
constraints_path,
400390
)
401-
if session.python == "3.8":
402-
extras = "[tests,alembic]"
403-
elif session.python in ["3.12", "3.13"]:
391+
if session.python in ["3.12", "3.13"]:
404392
extras = "[tests,geography]"
405393
else:
406394
extras = "[tests]"

owlbot.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,13 @@
3030
# ----------------------------------------------------------------------------
3131
extras = ["tests"]
3232
extras_by_python = {
33-
"3.8": ["tests", "alembic", "bqstorage"],
3433
"3.11": ["tests", "geography", "bqstorage"],
3534
"3.12": ["tests", "geography", "bqstorage"],
3635
"3.13": ["tests", "geography", "bqstorage"],
3736
}
3837
templated_files = common.py_library(
39-
unit_test_python_versions=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"],
40-
system_test_python_versions=["3.8", "3.12", "3.13"],
38+
unit_test_python_versions=["3.9", "3.10", "3.11", "3.12", "3.13"],
39+
system_test_python_versions=["3.12", "3.13"],
4140
cov_level=100,
4241
unit_test_extras=extras,
4342
unit_test_extras_by_python=extras_by_python,

0 commit comments

Comments
 (0)