-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: to_gbq
uses default_type
for ambiguous array types and struct field types
#838
Merged
+244
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
Issues related to the googleapis/python-bigquery-pandas API.
label
Dec 12, 2024
…o issue836-to_gbq-with-schema
…o issue836-to_gbq-with-schema
4 tasks
Tested with customer's code samples manually and confirmed this fixes the issue:
|
chalmerlowe
reviewed
Dec 16, 2024
chalmerlowe
reviewed
Dec 16, 2024
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
…leapis/python-bigquery-pandas into issue836-to_gbq-with-schema
chalmerlowe
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please accept and/or add docstrings.
- Please consider the other suggestions for inclusion, but not blockers.
Approving this PR based on addition of docstrings.
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
…o issue836-to_gbq-with-schema
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: m
Pull request size is medium.
labels
Dec 19, 2024
tswast
force-pushed
the
issue836-to_gbq-with-schema
branch
from
December 19, 2024 17:14
03f7128
to
7e23e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery-pandas API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Include fix to not detect schema if one is provided (or merge with the provided one if need be).N/A. There is merge logic so that users can provide a subset of the schema. I don't think it makes sense to modify that logic in this PR.Fixes #836 🦕