Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an "engine" parameter and context property to support bigframes DataFrame output #16

Closed
2 tasks
tswast opened this issue Apr 11, 2024 · 2 comments · Fixed by #60
Closed
2 tasks
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Apr 11, 2024

Sub-tasks:

  • Add a bigquery_magics.context.engine option which defaults to "pandas" but can be set to "bigframes" for %%bigquery to return a BigQuery DataFrames object.
  • The default option can also be overridden by specifying --engine="bigframes" in the first line of the %%bigquery magics.

Googlers, see go/bf-magics design.

@tswast tswast added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 11, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-magics API. label Apr 11, 2024
@tswast
Copy link
Collaborator Author

tswast commented Apr 11, 2024

Benefits for why the user might want to support this:

  • Support queries that return > 10 GB of results.
  • Hopefully some day: more natural "async" support so as not to block the current thread while the query runs.

@tswast
Copy link
Collaborator Author

tswast commented Aug 22, 2024

Another thought: We should use a code path that doesn't immediately run the query at read_gbq / read_gbq_query time (internal issue 347050555). Otherwise the magic would end up running at least two queries: the original query & one or two to visualize the results from __repr__.

@tswast tswast assigned sycai and unassigned chelsea-lin Aug 22, 2024
@sycai sycai added priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 11, 2024
@sycai sycai closed this as completed in #60 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants