Skip to content

Conversation

@GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested a review from shuoweil January 22, 2026 23:19
@GarrettWu GarrettWu self-assigned this Jan 22, 2026
@GarrettWu GarrettWu requested review from a team as code owners January 22, 2026 23:19
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 22, 2026
shuoweil
shuoweil previously approved these changes Jan 23, 2026
This change corrects the SQL generation for  and  to pass the options as a struct, which is the correct syntax.

The snapshot tests have been updated to reflect these changes.
@GarrettWu GarrettWu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 23, 2026
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 23, 2026
@GarrettWu GarrettWu removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 23, 2026
@shuoweil shuoweil self-requested a review January 26, 2026 19:32
@GarrettWu GarrettWu merged commit 5ac6810 into main Jan 26, 2026
26 of 27 checks passed
@GarrettWu GarrettWu deleted the garrettwu-bbq branch January 26, 2026 19:36
shuoweil added a commit that referenced this pull request Feb 3, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
<details><summary>bigframes: 2.34.0</summary>

##
[2.34.0](v2.33.0...v2.34.0)
(2026-02-02)


### Features

* add `bigframes.pandas.options.experiments.sql_compiler` for switching
the backend compiler (#2417)
([7eba6ee](7eba6ee))
* add bigquery.ml.generate_embedding function (#2422)
([35f3f5e](35f3f5e))
* add bigquery.create_external_table method (#2415)
([76db295](76db295))
* add deprecation warnings for .blob accessor and read_gbq_object_table
(#2408)
([7261a4e](7261a4e))
* add bigquery.ml.generate_text function (#2403)
([5ac6810](5ac6810))


### Bug Fixes

* broken job url (#2411)
([fcb5bc1](fcb5bc1))
shuoweil added a commit that referenced this pull request Feb 4, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677
<details><summary>bigframes: 2.34.0</summary>

##
[2.34.0](v2.33.0...v2.34.0)
(2026-02-02)


### Features

* add `bigframes.pandas.options.experiments.sql_compiler` for switching
the backend compiler (#2417)
([7eba6ee](7eba6ee))
* add bigquery.ml.generate_embedding function (#2422)
([35f3f5e](35f3f5e))
* add bigquery.create_external_table method (#2415)
([76db295](76db295))
* add deprecation warnings for .blob accessor and read_gbq_object_table
(#2408)
([7261a4e](7261a4e))
* add bigquery.ml.generate_text function (#2403)
([5ac6810](5ac6810))


### Bug Fixes

* broken job url (#2411)
([fcb5bc1](fcb5bc1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants