Skip to content

deps: replace google-cloud-iam with grpc-google-iam-v1 #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Jun 26, 2025

google-cloud-iam dependency was added for google.iam.v1.policy_pb2 module for the purpose of updating IAM policy for the BQ connection service account. It turns out that this was unnecessary. What was really needed was grpc-google-iam-v1 package, which is available via both bigframes -> google-cloud-resource-manager -> grpc-google-iam-v1 and bigframes -> google-cloud-iam -> grpc-google-iam-v1 dependencies. Since bigframes is making use of the policy_pb2 module directly, we are adding grpc-google-iam-v1 as direct dependency and removing the google-cloud-iam dependency in this change.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners June 26, 2025 23:21
@shobsi shobsi requested a review from sycai June 26, 2025 23:21
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 26, 2025
@shobsi shobsi requested a review from tswast June 27, 2025 00:37
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't. If we use the IAM module directly (which we do), don't depend on getting it via a transitive dependency.

@shobsi shobsi changed the title deps: remove google-cloud-iam dependency deps: replace google-cloud-iam with grpc-google-iam-v1 Jul 10, 2025
@shobsi shobsi requested a review from tswast July 10, 2025 07:52
@shobsi
Copy link
Contributor Author

shobsi commented Jul 10, 2025

Please don't. If we use the IAM module directly (which we do), don't depend on getting it via a transitive dependency.

Added grpc-google-iam-v1 dependency instead, PTAL, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants