feat: Pass options as struct to ML.PREDICT and ML.GLOBAL_EXPLAIN

This change corrects the SQL generation for  and  to pass the options as a struct, which is the correct syntax.

The snapshot tests have been updated to reflect these changes.

Author: GarrettWu

GEMINI.md

@@ -2,9 +2,9 @@
 
 ## Testing
 
-We use `pytest` to instrument our tests.
+We use `nox` to instrument our tests.
 
-- To test your changes, run unit tests with `pytest`:
+- To test your changes, run unit tests with `nox`:
 
   ```bash
   nox -r -s unit

bigframes/core/sql/ml.py

@@ -189,10 +189,10 @@ def predict(
         struct_options["trial_id"] = trial_id
 
     sql = (
-        f"SELECT * FROM ML.PREDICT(MODEL {googlesql.identifier(model_name)}, ({table}))"
+        f"SELECT * FROM ML.PREDICT(MODEL {googlesql.identifier(model_name)}, ({table})"
     )
     sql += _build_struct_sql(struct_options)
-    sql += "\n"
+    sql += ")\n"
     return sql
 
 
@@ -238,9 +238,9 @@ def global_explain(
     if class_level_explain is not None:
         struct_options["class_level_explain"] = class_level_explain
 
-    sql = f"SELECT * FROM ML.GLOBAL_EXPLAIN(MODEL {googlesql.identifier(model_name)})"
+    sql = f"SELECT * FROM ML.GLOBAL_EXPLAIN(MODEL {googlesql.identifier(model_name)}"
     sql += _build_struct_sql(struct_options)
-    sql += "\n"
+    sql += ")\n"
     return sql
 
 

tests/unit/core/sql/snapshots/test_ml/test_global_explain_model_with_options/global_explain_model_with_options.sql

@@ -1 +1 @@
-SELECT * FROM ML.GLOBAL_EXPLAIN(MODEL `my_model`), STRUCT(true AS class_level_explain)
+SELECT * FROM ML.GLOBAL_EXPLAIN(MODEL `my_model`, STRUCT(true AS class_level_explain))

tests/unit/core/sql/snapshots/test_ml/test_predict_model_with_options/predict_model_with_options.sql

@@ -1 +1 @@
-SELECT * FROM ML.PREDICT(MODEL `my_model`, (SELECT * FROM new_data)), STRUCT(true AS keep_original_columns)
+SELECT * FROM ML.PREDICT(MODEL `my_model`, (SELECT * FROM new_data), STRUCT(true AS keep_original_columns))