UPGRADING.md

2.0.0 Migration Guide

The 2.0 release of the google-cloud-asset client is a significant upgrade based on a next-gen code generator, and includes substantial interface changes. Existing code written for earlier versions of this library will likely require updates to use this version. This document describes the changes that have been made, and what you need to do to update your usage.

If you experience issues or have questions, please file an issue.

Supported Python Versions

WARNING: Breaking change

The 2.0.0 release requires Python 3.6+.

Method Calls

WARNING: Breaking change

Methods expect request objects. We provide a script that will convert most common use cases.

• Install the library with libcst.

python3 -m pip install google-cloud-asset[libcst]

• The script fixup_asset_v1_keywords.py is shipped with the library. It expects an input directory (with the code to convert) and an empty destination directory.

$ fixup_asset_v1_keywords.py --input-directory .samples/ --output-directory samples/

Before:

from google.cloud import asset

client = asset.AssetServiceClient()

feeds = client.list_feeds("folders/12345")

After:

from google.cloud import asset

client = asset.AssetServiceClient()

feeds = client.list_feeds(request = {'parent': "folders/12345"})

More Details

In google-cloud-asset<2.0.0, parameters required by the API were positional parameters and optional parameters were keyword parameters.

Before:

    def search_all_resources(
        self,
        scope,
        query=None,
        asset_types=None,
        page_size=None,
        order_by=None,
        retry=google.api_core.gapic_v1.method.DEFAULT,
        timeout=google.api_core.gapic_v1.method.DEFAULT,
        metadata=None,
    ):

In the 2.0.0 release, all methods have a single positional parameter request. Method docstrings indicate whether a parameter is required or optional.

Some methods have additional keyword only parameters. The available parameters depend on the google.api.method_signature annotation specified by the API producer.

After:

    def search_all_resources(
        self,
        request: asset_service.SearchAllResourcesRequest = None,
        *,
        scope: str = None,
        query: str = None,
        asset_types: Sequence[str] = None,
        retry: retries.Retry = gapic_v1.method.DEFAULT,
        timeout: float = None,
        metadata: Sequence[Tuple[str, str]] = (),
    ) -> pagers.SearchAllResourcesPager:

NOTE: The request parameter and flattened keyword parameters for the API are mutually exclusive. Passing both will result in an error.

Both of these calls are valid:

response = client.search_all_resources(
    request={
        "scope": scope,
        "query": query,
        "asset_types": asset_types,
    }
)

response = client.search_all_resources(
    scope=scope,
    query=query,
    asset_types=asset_types
)

This call is invalid because it mixes request with a keyword argument asset_types. Executing this code will result in an error.

response = client.search_all_resources(
    request={
        "scope": scope,
        "query": query,
    },
    asset_types=asset_types
)

Enums and Types

WARNING: Breaking change

The submodules enums and types have been removed.

Before:

from google.cloud import asset

resource = asset.enums.ContentType.RESOURCE
cloud_asset = asset.types.Asset(name="name")

After:

from google.cloud import asset

resource = asset.ContentType.RESOURCE
cloud_asset = asset.Asset(name="name")

Project Path Helper Methods

The project path helper method project_path has been removed. Please construct this path manually.

project = 'my-project'
project_path = f'projects/{project}'