Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to pyproject.toml #736

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: migrate to pyproject.toml #736

wants to merge 17 commits into from
+108 −117

Conversation

rinarakaki
Copy link
Contributor

@rinarakaki rinarakaki commented Oct 15, 2024 •
edited
Loading

Tracking issue googleapis/google-cloud-python#13171

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki rinarakaki requested review from a team as code owners October 15, 2024 03:47
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 15, 2024
This was referenced Oct 15, 2024
Open
Open
Open
@rinarakaki rinarakaki changed the title feature: migrate to pyproject.toml feat: migrate to pyproject.toml Oct 16, 2024
@rinarakaki rinarakaki mentioned this pull request Oct 16, 2024
Open
15 tasks
@parthea parthea self-assigned this Oct 19, 2024
parthea
parthea approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rinarakaki!

pyproject.toml Show resolved Hide resolved
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 19, 2024
@parthea
Copy link
Collaborator

parthea commented Oct 19, 2024

Adding do not merge until #729 is merged to avoid delaying the Python 3.13 release.

parthea
parthea reviewed Oct 19, 2024
View reviewed changes
pyproject.toml Outdated
dependencies = [
"googleapis-common-protos >= 1.56.2, < 2.0.dev0",
"protobuf>=3.19.5,<6.0.0.dev0,!=3.20.0,!=3.20.1,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",
"proto-plus >= 1.22.3, <2.0.0dev",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"proto-plus >= 1.22.3, <2.0.0dev",
"proto-plus >= 1.22.3, <2.0.0dev",
"proto-plus >= 1.25.0, <2.0.0dev; python_version>='3.13'",

This should be updated once #737 and googleapis/proto-plus-python#495 are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees

@parthea parthea

Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinarakaki @parthea @vchudnov-g