Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the type hint for credentials parameter in OperationsTransport class #709

Open
ohmayr opened this issue Oct 1, 2024 · 0 comments
Open

Update the type hint for credentials parameter in OperationsTransport class #709

ohmayr opened this issue Oct 1, 2024 · 0 comments
Assignees
@parthea
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Oct 1, 2024

Update the type hint for credentials parameter in the base OperationsTransport class to include google.auth.aio.credentials.Credentials.

As a follow up, remove # type: ignore from the relevant code locations which suppresses mypy errors.
@vchudnov-g vchudnov-g added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 1, 2024
@github-actions github-actions bot mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parthea @vchudnov-g @ohmayr