Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'proto.Message' classes to 'get_messages()' helper #61

Open
plamut opened this issue Jul 15, 2020 · 2 comments
Open

Add support for 'proto.Message' classes to 'get_messages()' helper #61

plamut opened this issue Jul 15, 2020 · 2 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@plamut
Copy link
Contributor

plamut commented Jul 15, 2020

I noticed that protobuf messages generated with the new microgenerator subclass proto.Message, meaning they are not instances of google.protobuf.message.Message anymore. This causes the protobuf_helpers.get_messages() helper to omit them from the result.

As a library developer, I would like the helper to work with proto.Messages, too, or have a new helper available for these new message types.
@plamut plamut added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 15, 2020
@plamut plamut changed the title get_messages() helper does not discover proto.Message module members get_messages() helper does not discover module members of type proto.Message Jul 15, 2020
@busunkim96
Copy link
Contributor

@software-dov Is there an easy way to do this proto-plus?

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Oct 14, 2020
@tseaver tseaver changed the title get_messages() helper does not discover module members of type proto.Message Add support for 'proto.Message' classes to 'get_messages()' helper Dec 8, 2020
@tseaver tseaver added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 8, 2020
@tseaver
Copy link
Contributor

tseaver commented Dec 8, 2020 •
edited
Loading

See Peter's workaround in python-pubsub.

One issue is that api_core does not currently depend on proto-plus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tseaver @plamut @busunkim96 @yoshi-automation