Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Reset Connection as a first class exception in api_core #60

Open
frankyn opened this issue Jul 7, 2020 · 1 comment
Open

Support Reset Connection as a first class exception in api_core #60

frankyn opened this issue Jul 7, 2020 · 1 comment
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frankyn
Copy link
Member

frankyn commented Jul 7, 2020

Is your feature request related to a problem? Please describe.
Users are continuously experiencing reset connection errors which are retried in https://github.com/googleapis/google-api-python-client/releases/tag/v1.8.1. At the moment the error needs to be handled outside of the api_core package instead of being part of one of the supported exceptions in https://github.com/googleapis/python-api-core/blob/master/google/api_core/exceptions.py#L336 and surfaces transport library types when it should be wrapped.

Describe the solution you'd like
Include Reset Connection as a first class citizen in https://github.com/googleapis/python-api-core/blob/master/google/api_core/exceptions.py#L336

Describe alternatives you've considered
Including reset connection into library retry code manually for each manual library. It can instead be handled generally in api_core instead.

cc: @crwilcox @busunkim96 @tritone @shollyman

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 7, 2020
@busunkim96 busunkim96 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jul 8, 2020
@frankyn
Copy link
Member Author

frankyn commented Jul 9, 2020

Discussed offline with the group:

The changes necessary to support this error:

  1. Update api-core to support the ResetConnection error as an exception class.
  2. Update cloud-core to catch the underlying HTTP reset connection error and wrap it as a ResetConnection error defined in api-core.

This is only true while the libraries are split into two parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants