Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protobuf version to ClientInfo instance (i.e. user agent) #416

Open
BenRKarl opened this issue Jul 19, 2022 · 1 comment
Open

Add protobuf version to ClientInfo instance (i.e. user agent) #416

BenRKarl opened this issue Jul 19, 2022 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@BenRKarl
Copy link

BenRKarl commented Jul 19, 2022

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.

No, just a feature request.

Describe the solution you'd like

When initializing an instance of ClientInfo, i.e.:

from google.api_core.gapic_v1.client_info import ClientInfo

client_info = ClientInfo()

It should, by default, include the current version of protobuf just like it already does for grpc and other libraries:

client_info.to_user_agent()
>>> "gl-python/3.7.2 grpc/5.5.5 rest/1.1.1 gax/3.3.3 gapic/2.2.2 gccl/1.1.1 pb/4.21.2"

Describe alternatives you've considered

Alternatively we could manually append the protobuf version to the user agent in our library, but it seems cleaner to gather these dependency versions in one location.

@vchudnov-g vchudnov-g added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 19, 2022
@vchudnov-g
Copy link
Contributor

Thanks for the feature request! I replied internally with some additional details. Providing some information on the motivation for this request would also be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants